989058 - Some cumulative theme fixes

Status: VERIFIED FIXED

(DevTools :: General, defect, P1)

Description

[Rob Campbell [:rc] (:robcee)]

Devtools should have more chalupuiles in its chrome.

Comment 1

[Joe Walker [:jwalker]]

Chrome is Lithophile, not Chalcophile.

I suspect that WAT, WONTFIX is a better response, but I'll start with WAT.

WAT?

Comment 2

[Rob Campbell [:rc] (:robcee)]

Attachment: brushed-metal

Comment 3

[Rob Campbell [:rc] (:robcee)]

Dave and I were joking about landing a Brushed Metal theme for April 1st.

I'll be the first to admit that April Fool's gags on the internet are cheap, annoying and a source of unpleasantness for a lot of people.

But a Brushed Metal Theme...

http://cl.ly/UhAG

If we agree to do this, we land this on Sunday, back it out on Monday after the nightly's been built.

I'm pretty on-the-fence about this. I don't want to hurt our reputation by letting our users think we might land something frivolous at any time. Then again, it's "just" nightly.

What do you all think?

Comment 4

[Rob Campbell [:rc] (:robcee)]

oh, and in case anyone's wondering what a "chalupuiles" is, it is a fictional breakfast food from Taco Bell that is part Chilaquiles, part Chalupa. I made it up.

Comment 5

[Rob Campbell [:rc] (:robcee)]

I'm just gonna wontfix this. It's a bad idea, though I had a giggle making it.

Comment 6

[Joe Walker [:jwalker]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #3)
> Dave and I were joking about landing a Brushed Metal theme for April 1st.
> 
> I'll be the first to admit that April Fool's gags on the internet are cheap,
> annoying and a source of unpleasantness for a lot of people.
> 
> But a Brushed Metal Theme...
> 
> http://cl.ly/UhAG
> 
> If we agree to do this, we land this on Sunday, back it out on Monday after
> the nightly's been built.
> 
> I'm pretty on-the-fence about this. I don't want to hurt our reputation by
> letting our users think we might land something frivolous at any time. Then
> again, it's "just" nightly.
> 
> What do you all think?

Is that comic sans? +1 if it's comic sans.

Comment 7

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Think we shouldn't be so brash and give this some more thought.

Comment 8

[Victor Porof [:vporof][:vp]]

I think this would actually be fun if it landed. People using Nightly *must* have a sense of humor, otherwise they wouldn't be on Nightly.

Comment 9

[Rob Campbell [:rc] (:robcee)]

yeah, it's comic sans. (Purisa as a fallback for linux)

I dunno...

Comment 10

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Will it be the default theme? Will it be a separate theme from light and dark? Will there be a doge-themed background-image for the options panel?

Doesn't really matter, just ship it (and then un-ship it or optionally hide it behind a pref)

Comment 11

[Victor Porof [:vporof][:vp]]

It should probably be the only and default theme :)

Comment 12

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Victor Porof [:vporof][:vp] from comment #11)
> It should probably be the only and default theme :)

+1!

Comment 13

[Brandon Benvie [:benvie]]

This really has to happen.

Comment 14

[Angelina Fabbro (:angelina)]

I've never been so delighted to read bugmail at 2am on a weekend.

Comment 15

[Rob Campbell [:rc] (:robcee)]

seems like we have some semblance of consensus. I am suitably terrified.

This patch forcibly switches to the light theme and wedges the brushed metal into that theme. Comic Sans on the toolbars (purisa as fallback for linux).

One issue is the funny background edges in the breadcrumbs. Not sure I care? Anybody want to take a crack at it?

Comment 16

[Rob Campbell [:rc] (:robcee)]

oh, and the options panel has only one theme option available: "Metal".

Comment 17

[Panos Astithas (he/him) [:past] (please ni?)]

I'm also +1 on this!

Having a second theme in the options panel would be more "safe" and less likely to stir a firestorm, but in light of recent events I think even so a change in context would be actually welcome, and what we are mostly craving for right now is "fun".

Comment 18

[Matteo Ferretti [:zer0] [:matteo]]

Now I want to file a bug like "devtools should be more user friendly: adds more puppies in its chrome should do the job".

Comment 19

[Brian Grinstead [:bgrins]]

Comment on attachment 8398511 [details] [diff] [review]
brushed-metal

Review of attachment 8398511 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/gDevTools.jsm
@@ +34,4 @@
>  
>    this._testing = false;
>  
> +  Services.prefs.setCharPref("devtools.theme", "light");

Instead of setting the pref here, I would suggest to modify theme-switching.js line 82 to just hardcode "light".  This will have the bonus of it automatically switching back to their default afterwards.

Comment 20

[Rob Campbell [:rc] (:robcee)]

(In reply to Brian Grinstead [:bgrins] from comment #19)
> Comment on attachment 8398511 [details] [diff] [review]
> brushed-metal
> 
> Review of attachment 8398511 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/devtools/framework/gDevTools.jsm
> @@ +34,4 @@
> >  
> >    this._testing = false;
> >  
> > +  Services.prefs.setCharPref("devtools.theme", "light");
> 
> Instead of setting the pref here, I would suggest to modify
> theme-switching.js line 82 to just hardcode "light".  This will have the
> bonus of it automatically switching back to their default afterwards.

great suggestion. Was wondering if we could cache the previous setting somehow.

Comment 21

[Dave Camp (:dcamp)]

comic sans might be a *bit* much.

Comment 22

[Brian Grinstead [:bgrins]]

Comment on attachment 8398511 [details] [diff] [review]
brushed-metal

Review of attachment 8398511 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/toolbox-options.xul
@@ -33,4 @@
>                      class="options-groupbox"
>                      data-pref="devtools.theme"
>                      orient="horizontal">
> -          <radio value="light" label="&options.lightTheme.label;"/>

With my previous selection, the metal theme wouldn't be selected if your pref was dark.  I would suggest to remove the data-pref from radio group, and set checked="true" on the metal theme.  Also, it could be fun to include light and dark theme as disabled options: 

        <radiogroup id="devtools-theme-box"
                    class="options-groupbox"
                    orient="horizontal">
          <radio checked="true" value="light" label="Metal"/>
          <radio checked="false" disabled="true" value="light" label="&options.lightTheme.label;"/>
          <radio checked="false" disabled="true" value="dark" label="&options.darkTheme.label;"/>
        </radiogroup>

Comment 23

[Brian Grinstead [:bgrins]]

(In reply to Dave Camp (:dcamp) from comment #21)
> comic sans might be a *bit* much.

Comic Sans ties everything together.  How can you look at this and not love it? https://www.dropbox.com/s/gk7p2s5goa34bsw/Screenshot%202014-03-31%2010.10.58.png

Comment 24

[Victor Porof [:vporof][:vp]]

(In reply to Brian Grinstead [:bgrins] from comment #23)

Not enough Comic Sans. Needs more monospaced Comic Sans. Why aren't we funding a monospaced version of Comic Sans?

Comment 25

[Brian Grinstead [:bgrins]]

Comment on attachment 8398511 [details] [diff] [review]
brushed-metal

Review of attachment 8398511 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, and if you want to fix the breadcrumb issue, widgets.inc.css line 162: 

.theme-light #breadcrumb-separator-after,
.theme-light #breadcrumb-separator-before:after {
  background: url("chrome://browser/skin/devtools/metal.jpg"); /* Toolbars */
}

Comment 26

[Dave Townsend [:mossop]]

Comment on attachment 8398511 [details] [diff] [review]
brushed-metal

Review of attachment 8398511 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/framework/toolbox-options.xul
@@ +33,4 @@
>                      class="options-groupbox"
>                      data-pref="devtools.theme"
>                      orient="horizontal">
> +          <radio value="light" label="Metal"/>

A minor niggle perhaps but you're going to destroy blame for this line by doing this

Comment 27

[Rob Campbell [:rc] (:robcee)]

(In reply to Dave Townsend (:Mossop) from comment #26)
> Comment on attachment 8398511 [details] [diff] [review]
> brushed-metal
> 
> Review of attachment 8398511 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/devtools/framework/toolbox-options.xul
> @@ +33,4 @@
> >                      class="options-groupbox"
> >                      data-pref="devtools.theme"
> >                      orient="horizontal">
> > +          <radio value="light" label="Metal"/>
> 
> A minor niggle perhaps but you're going to destroy blame for this line by
> doing this

even after we back this out?

Comment 28

[Rob Campbell [:rc] (:robcee)]

Attachment: brushed-metal

Comment 29

[Rob Campbell [:rc] (:robcee)]

Attachment: Screen Shot.png

Comment 30

[Rob Campbell [:rc] (:robcee)]

Attachment: options

Comment 31

[Dave Townsend [:mossop]]

(In reply to Rob Campbell [:rc] (:robcee) from comment #27)
> (In reply to Dave Townsend (:Mossop) from comment #26)
> > Comment on attachment 8398511 [details] [diff] [review]
> > brushed-metal
> > 
> > Review of attachment 8398511 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: browser/devtools/framework/toolbox-options.xul
> > @@ +33,4 @@
> > >                      class="options-groupbox"
> > >                      data-pref="devtools.theme"
> > >                      orient="horizontal">
> > > +          <radio value="light" label="Metal"/>
> > 
> > A minor niggle perhaps but you're going to destroy blame for this line by
> > doing this
> 
> even after we back this out?

Yes, the backout will cause the blame for that line to just be the backout changeset.

Comment 32

[Dave Camp (:dcamp)]

Comment on attachment 8399486 [details] [diff] [review]
brushed-metal

r+ and preemptive r+ for the backout.

Comment 33

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8399486 [details] [diff] [review]
brushed-metal

Review of attachment 8399486 [details] [diff] [review]:
-----------------------------------------------------------------

8 lines of context Rob, geez!

https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

::: browser/devtools/framework/toolbox-options.xul
@@ +34,3 @@
>                      orient="horizontal">
> +          <radio checked="true" value="light" label="Metal"/>
> +          <radio checked="false" disabled="true" value="light" label="&options.lightTheme.label;"/>

If you're just modifying the light theme, maybe it makes sense to remove the light theme option?

::: browser/devtools/shared/theme-switching.js
@@ +79,4 @@
>    const StylesheetUtils = devtools.require("sdk/stylesheet/utils");
>  
>    let theme = Services.prefs.getCharPref("devtools.theme");
> +  switchTheme("light");

Can we add a date check for April first and only do the metal theme that day?

This would require some refactoring, I suppose.

Comment 34

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8399486 [details] [diff] [review]
brushed-metal

Woops, didn't mean to undo dcamp's r+

Comment 35

[Rob Campbell [:rc] (:robcee)]

(In reply to Nick Fitzgerald [:fitzgen] from comment #33)
> Comment on attachment 8399486 [details] [diff] [review]
> brushed-metal
> 
> Review of attachment 8399486 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> 8 lines of context Rob, geez!
> 
> https://developer.mozilla.org/en-US/docs/
> Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-
> in_for_me.3F
> 
> ::: browser/devtools/framework/toolbox-options.xul
> @@ +34,3 @@
> >                      orient="horizontal">
> > +          <radio checked="true" value="light" label="Metal"/>
> > +          <radio checked="false" disabled="true" value="light" label="&options.lightTheme.label;"/>
> 
> If you're just modifying the light theme, maybe it makes sense to remove the
> light theme option?
> 
> ::: browser/devtools/shared/theme-switching.js
> @@ +79,4 @@
> >    const StylesheetUtils = devtools.require("sdk/stylesheet/utils");
> >  
> >    let theme = Services.prefs.getCharPref("devtools.theme");
> > +  switchTheme("light");
> 
> Can we add a date check for April first and only do the metal theme that day?
> 
> This would require some refactoring, I suppose.

sadly no. It'd require the addition of a full brushed-metal theme and we just don't have that kinda time.

Comment 36

[Brandon Benvie [:benvie]]

This is so metal. Looks good on Windows.

Comment 37

[Brian Grinstead [:bgrins]]

(In reply to Brandon Benvie [:benvie] from comment #36)
> This is so metal. Looks good on Windows.

Define "good"

Comment 38

[Rob Campbell [:rc] (:robcee)]

"metal"

Comment 39

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/8d720133605f

Comment 40

[Brandon Benvie [:benvie]]

(In reply to Brian Grinstead [:bgrins] from comment #37)
> (In reply to Brandon Benvie [:benvie] from comment #36)
> > This is so metal. Looks good on Windows.
> 
> Define "good"

Looks metal with an excellent new typography choice.

Comment 41

[Dave Townsend [:mossop]]

*realises that this will ruin getting a screencast of the new add-on debugger done tomorrow*

Comment 42

[Jeff Griffiths (:canuckistani) (:⚡︎)]

(In reply to Dave Townsend (:Mossop) from comment #41)
> *realises that this will ruin getting a screencast of the new add-on
> debugger done tomorrow*

I don't see why.

Comment 43

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8d720133605f

Comment 44

[Girish Sharma [:Optimizer]]

(leave open)

Comment 45

[Mihai Sucan [:msucan]]

This is really good april's fool joke. Funny enough that I had to back it out today on my local repo. :) it's THAT good.

Comment 47

[Victor]

Sorry to be that guy, but not allowing to change theme at all was to take this a bit too far. It's funny until you try to use it.

Comment 48

[Rob Campbell [:rc] (:robcee)]

Attachment: backout.patch

Comment 49

[Rob Campbell [:rc] (:robcee)]

backed-out

https://hg.mozilla.org/integration/fx-team/rev/a4fbdc403e0f

Comment 50

[Tim Nguyen :ntim]

Nice joke :)

Comment 51

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a4fbdc403e0f

Comment 52

[Firefox Commit Bot]

The following changeset is now in Firefox Nightly:

> a4fbdc403e0f Bug 989058 - Some cumulative theme fixes - BACKOUTOMG; r=dcamp,#developers

Nightly Build Information:

        ID: 20140402030201
 Changeset: 4941a2ac0786109b08856738019b016a6c5a66a6
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=4941a2ac0786
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central

Download Links:

>         Linux x86: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-i686.tar.bz2
>      Linux x86_64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64.tar.bz2
> Linux x86_64 ASAN: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.linux-x86_64-asan.tar.bz2
>               Mac: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.mac.dmg
>             Win32: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win32.installer.exe
>             Win64: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-02-03-02-01-mozilla-central/firefox-31.0a1.en-US.win64-x86_64.installer.exe

Previous Nightly Build Information:

        ID: 20140401030203
 Changeset: 1417d180a1d8665b1a91b897d1cc4cc31e7980d4
   Version: 31.0a1
      TBPL: https://tbpl.mozilla.org/?rev=1417d180a1d8
       URL: https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014/04/2014-04-01-03-02-03-mozilla-central